Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge NuGet.SolutionRestoreManager.Interop into NuGet.VisualStudio #10957

Closed
zivkan opened this issue Jun 21, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4120
Closed

Merge NuGet.SolutionRestoreManager.Interop into NuGet.VisualStudio #10957

zivkan opened this issue Jun 21, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4120
Assignees
@zivkan
Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:DCR Design Change Request
Milestone
Sprint 2021-06

Comments

@zivkan
Copy link
Member

zivkan commented Jun 21, 2021

Visual Studio 2022 (dev17)'s SDK has stopped using EmbedInteropTypes. NuGet also made the same change in NuGet 6.0 (which targets dev17).

All the APIs in NuGet.SolutionRestoreManager.Interop will also be moved into the NuGet.VisualStudio package, and the namespace for all the APIs will be moved from NuGet.SolutionRestoreManager to NuGet.VisualStudio.

This avoids a new assembly (NuGet.SolutionRestoreManager.Interop.dll) being loaded by Visual Studio, which has a very minor performance benefit (memory reduction).
@zivkan zivkan added Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request labels Jun 21, 2021
@zivkan zivkan added this to the Sprint 2021-06 milestone Jun 21, 2021
@zivkan zivkan self-assigned this Jun 21, 2021
@zivkan zivkan mentioned this issue Jun 21, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Milestone
Sprint 2021-06
Development

Successfully merging a pull request may close this issue.

Merge NuGet.SolutionRestoreManager.Introp into NuGet.VisualStudio NuGet/NuGet.Client
1 participant
@zivkan