Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a pooled byte array when copying files and validating signatures #10988

Closed
nkolev92 opened this issue Jul 1, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4134
Closed

Use a pooled byte array when copying files and validating signatures #10988

nkolev92 opened this issue Jul 1, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4134
Assignees
@nkolev92
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
Sprint 2021-07

Comments

@nkolev92
Copy link
Member

nkolev92 commented Jul 1, 2021

Given that files, especially nupkgs, tend to be larger than 81kb, it's very practical to use an array pool for that.

This could save GB in allocations when dealing with a clean restore.
@nkolev92 nkolev92 added Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug labels Jul 1, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-06 milestone Jul 1, 2021
@nkolev92 nkolev92 added the Community PRs (and linked Issues) created by someone not in the NuGet team label Jul 1, 2021
@nkolev92 nkolev92 self-assigned this Jul 1, 2021
@nkolev92 nkolev92 mentioned this issue Jul 1, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
Sprint 2021-07
2 participants
@nkolev92 @kartheekp-ms