Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Task.WhenAny allocations in dependency walker #10989

Closed
nkolev92 opened this issue Jul 1, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4135
Closed

Avoid Task.WhenAny allocations in dependency walker #10989

nkolev92 opened this issue Jul 1, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4135
Assignees
@nkolev92
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
Sprint 2021-07

Comments

@nkolev92
Copy link
Member

nkolev92 commented Jul 1, 2021

CreateGraphNode ends up on waiting on all dependency resolve tasks in a pretty inefficient manner, causing lots of unneeded allocations due to Task.WhenAny's defensive copying of the passed in list.
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Type:Bug Tenet:Performance Performance issues Functionality:Restore Community PRs (and linked Issues) created by someone not in the NuGet team labels Jul 1, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-06 milestone Jul 1, 2021
@nkolev92 nkolev92 mentioned this issue Jul 1, 2021
Merged
8 tasks
@nkolev92 nkolev92 self-assigned this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Community PRs (and linked Issues) created by someone not in the NuGet team Functionality:Restore Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
Sprint 2021-07
Development

Successfully merging a pull request may close this issue.

Avoid Task.WhenAny allocations in dependency walker davkean/NuGet.Client
1 participant
@nkolev92