Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the namespaces filtering is respected in packages.config package installation/updates IVs installer API #11002

Closed
erdembayar opened this issue Jul 7, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4154
Assignees
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Install The install command in VS/nuget.exe Priority:2 Issues for the current backlog. Style:Packages.Config Type:Bug

Comments

@erdembayar
Copy link
Contributor

erdembayar commented Jul 7, 2021

In PR, restore and package installation are equivalent.
In PC they are not.

This task covers ensuring that the namespaces are respected during package installation.

Detailed explanation:

Below is clarification from @zivkan

Our NuGet extensibility in Visual Studio docs detail our IVs* APIs. Also see the interface definitions, particularly IVsPackageInstaller.cs (and IVsPackageInstaller2).

Roslyn use it when you have two projects in the solution, one of them use a package, and the other does not. When you write code in the project that does not use the package, Roslyn will give you a lightbulb fix to install the package into the project.

Another way to test it is via our API testing extension

@nkolev92
Copy link
Member

@erdembayar we don't really use half days in estimates.

Can you please not adjust the estimates? It messes with the tracking in https://github.com/NuGet/Client.Engineering/issues/1026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Install The install command in VS/nuget.exe Priority:2 Issues for the current backlog. Style:Packages.Config Type:Bug
Projects
None yet
3 participants