IVsSolutionRestoreService4 should extend IVsSolutionRestoreService3 #11098
Labels
Functionality:SDK
The NuGet client packages published to nuget.org
Partner:Project-System
Priority:2
Issues for the current backlog.
Product:VS.Client
Type:Bug
Milestone
@davkean requested that
IVsSolutionRestoreService4
should extend, or re-implement all the methods fromIVsSolutionRestoreService3
. This avoids needing to MEF import two interfaces.While
IVsSolutionRestoreService3
andIVsSolutionRestoreService2
do not extend the lower numbered interfaces, they are used independently. Anyone usingIVsSolutionRestoreService3
will not be usingIVsSolutionRestoreService
. However, anyone usingIVsSolutionRestoreService4
must also useIVsSolutionRestoreService3
, it cannot be used independently. Technically, a caller usingIVsSolutionRestoreService4
could useIVsSolutionRestoreService
, butIVsSolutionRestoreService3
is a superset to support additional properties, so the older interface should probably be deprecated (but is out of scope for this issue).Using MEF is different to using VS services (
GetService<T1, T2>()
), where you get the implementation of the service and then cast it to the interface, so VS's COM interfaces that do not (always) extend older interfaces is a different scenario, so should not be taken as precedent./cc @nkolev92 @ocallesp
The text was updated successfully, but these errors were encountered: