Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VsCoreProjectSystemReferenceReader+<GetProjectReferencesAsync>d__ - managed projects #11163

Closed
nkolev92 opened this issue Aug 18, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4327
Assignees
Labels
Category:Quality Week Issues that should be considered for quality week PerfWins Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug

Comments

@nkolev92
Copy link
Member

nkolev92 commented Aug 18, 2021

During mixed project restores, this UI delay can happen.

1257734
1426094

When managed projects are involved, we are doing a very inefficient walk in https://github.com/NuGet/NuGet.Client/blob/c1a0597e5498bcf3bf0938b3dd0170edbf0b2d20/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/ProjectServices/VsCoreProjectSystemReferenceReader.cs#L54.

This issue tracks rewriting that.

cc @davkean

@nkolev92 nkolev92 assigned nkolev92 and unassigned nkolev92 Aug 18, 2021
@nkolev92 nkolev92 added Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:Performance Performance issues Type:Bug labels Aug 18, 2021
@nkolev92 nkolev92 self-assigned this Aug 18, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-09 milestone Aug 18, 2021
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Aug 18, 2021
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Quality Week Issues that should be considered for quality week PerfWins Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Projects
None yet
2 participants