Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid MEF lookups on UI thread during NuGet projects initialization #11176

Closed
nkolev92 opened this issue Aug 24, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4217
Closed

Avoid MEF lookups on UI thread during NuGet projects initialization #11176

nkolev92 opened this issue Aug 24, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4217
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Milestone
Sprint 2021-08

Comments

@nkolev92
Copy link
Member

Dup of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1384749.

Discovered as part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1331835.

GetGlobalService calls in the project system services happen on the UI thread.

For large solutions that can cause us to spend some considerable time on the UI thread.
Using composition avoid this.
@nkolev92 nkolev92 added Product:VS.Client Priority:2 Issues for the current backlog. Type:Bug Tenet:Performance Performance issues Category:Quality Week Issues that should be considered for quality week labels Aug 24, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-08 milestone Aug 24, 2021
@nkolev92 nkolev92 self-assigned this Aug 24, 2021
@nkolev92 nkolev92 mentioned this issue Aug 24, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
Sprint 2021-08
Development

Successfully merging a pull request may close this issue.

Avoid MEF lookups on UI thread NuGet/NuGet.Client
1 participant
@nkolev92