Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: MSBuild restore is logging exception as warning #11179

Closed
erdembayar opened this issue Aug 24, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4248
Closed

[Bug]: MSBuild restore is logging exception as warning #11179

erdembayar opened this issue Aug 24, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4248
Assignees
@erdembayar
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:Restore Type:Bug
Milestone
Sprint 2021-09

Comments

@erdembayar
Copy link
Contributor

NuGet Product Used

MSBuild.exe

Product Version

16.11.0.36601

Worked before?

n/a

Impact

Other

Repro Steps & Context

While debugging test I noticed some exceptions in msbuild restore task logging exception message as warning, I believe it should log as error instead.

image

Verbose Logs

No response
@erdembayar erdembayar added Type:Bug Area:ErrorHandling warnings and errors/log messages & related error codes. Functionality:Restore Triage:Untriaged labels Aug 24, 2021
@erdembayar erdembayar mentioned this issue Aug 24, 2021
Merged
8 tasks
@aortiz-msft aortiz-msft added the Category:Quality Week Issues that should be considered for quality week label Sep 2, 2021
@aortiz-msft aortiz-msft added this to the Sprint 2021-08 milestone Sep 2, 2021
@nkolev92
Copy link
Member

nkolev92 commented Sep 2, 2021

Keep in mind that the problem is not that this is a warning. The problem is that there's no error, yet a failure return code.

Please validate the same scenario with nuget.exe

@erdembayar erdembayar mentioned this issue Sep 5, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdembayar erdembayar

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:Restore Type:Bug
Projects
None yet
Milestone
Sprint 2021-09
Development

Successfully merging a pull request may close this issue.

Fix MSBuild restore is logging exception as warning NuGet/NuGet.Client
4 participants
@nkolev92 @erdembayar @kartheekp-ms @aortiz-msft