Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable annotations to NuGet.Frameworks #12570

Closed
zivkan opened this issue May 2, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5155
Closed

Add nullable annotations to NuGet.Frameworks #12570

zivkan opened this issue May 2, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5155
Assignees
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request
Milestone

Comments

@zivkan
Copy link
Member

zivkan commented May 2, 2023

NuGet Product(s) Affected

NuGet SDK

Current Behavior

Currently NuGet.Frameworks doesn't have annotations to allow the compiler to work with the compiler's "nullable reference types" feature.

Desired Behavior

Add null annotations, so the compiler knows when null might be returned, and when it's definitely not.

Additional Context

Anyone using NuGet.Frameworks in their project might find that upgrading to the newer version of NuGet.Frameworks might result in compiler warnings or errors, depending on if your project opts into nullable checks.

Additionally, it may be that while annotating the project that null-related bugs are found and fixed. Any app that depends on the behaviour considered buggy might find their app behaves differently since NuGet.Frameworks might throw exceptions when it previously didn't, or have a different result for the same inputs.

@zivkan zivkan added Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request labels May 2, 2023
@zivkan zivkan added this to the 6.7 milestone May 2, 2023
@zivkan zivkan self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant