Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vulnerable label doesn’t show in the “version” dropdown box of “Browse” tab when searching for vulnerable packages #12623

Closed
CiciLi1 opened this issue May 31, 2023 · 4 comments · Fixed by NuGet/NuGet.Client#5204 or NuGet/NuGet.Client#5287
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug
Milestone

Comments

@CiciLi1
Copy link

CiciLi1 commented May 31, 2023

NuGet Product Used

Visual Studio Package Management UI

Product Version

NuGet Client Dev\6.7.0.51

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Repro Steps:     

  1. Create a C# Console App (.NET Core 8.0) project.   

  2. Right-click the project in Solution Explorer and select "Manage NuGet Packages…" menu item to open the PM UI.

  3. Select the package source: “nuget.org” near the gear button.

  4. Go to "Browse" tab, search a package “Newtonsoft.Json” which have vulnerable versions and expand the "Version" drop-down box in the right panel.

Expected:     

The vulnerable label should show in the “version” dropdown box of “Browse” tab when searching for vulnerable packages

Actual:     

The vulnerable label doesn’t show in the “version” dropdown box of “Browse” tab when searching for vulnerable packages below screenshot:
image

Notes:  

1.The repro rate is 100%.  
2. It doesn’t repro on Dev\6.7.0.50 since the feature changed from Dev\6.7.0.51.
3. It does not repro when no vulnerable packages are searched as below screenshot:
image

Verbose Logs

No response

@martinrrm
Copy link
Contributor

This is not a bug, what is happening is that Recommended packages (first 5 with a star) use a different search API that brings vulnerabilities for each version and we can display that in the version combobox.

But in the registration search API, this information is not available and we can not display the label in the combobox, when you click a version we query the metadata and then we display the Vulnerability/Deprecation warning.

This behavior is the same for Deprecation.

@martinrrm
Copy link
Contributor

Deprecation:

image
image

@jeffkl jeffkl added the Resolution:ByDesign This issue appears to be ByDesign label May 31, 2023
@jeffkl
Copy link
Contributor

jeffkl commented May 31, 2023

Closing this issue for now as by design.

@jeffkl jeffkl closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@martinrrm martinrrm reopened this Jun 1, 2023
@martinrrm
Copy link
Contributor

This is actually a bug, this version should be available already. Looks like this is a cache problem

@jeffkl jeffkl removed Resolution:ByDesign This issue appears to be ByDesign Triage:Untriaged labels Jun 1, 2023
@martinrrm martinrrm added the Priority:1 High priority issues that must be resolved in the current sprint. label Jun 1, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 30, 2023
@nkolev92 nkolev92 modified the milestones: 6.7, 6.8 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug
Projects
None yet
5 participants