Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETW events should use default '/' instead of '_' #12631

Closed
DevPaulLiu opened this issue Jun 6, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5206
Closed

ETW events should use default '/' instead of '_' #12631

DevPaulLiu opened this issue Jun 6, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5206
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team PerfWins Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Milestone

Comments

@DevPaulLiu
Copy link

NuGet Product Used

Visual Studio Package Manager Console

Product Version

N/A

Worked before?

N/A

Impact

None

Repro Steps & Context

There is an issue in performance tests, not sure if this impact any of NuGet telemetry monitors.

As per David Kean:
We should avoid converting event/property names in ETW provider
This is allocating a lot during solution close and other places where lots of events are being produced, which is causing GCs to occur in some runs, introducing noise. The statement that says ETW events can't have '/' seems to be incorrect, as Windows, VS & .NET all include events with '/'. Also stopped converting properties as these are raw strings.

Verbose Logs

No response

@nkolev92 nkolev92 added Product:VS.Client Priority:2 Issues for the current backlog. Community PRs (and linked Issues) created by someone not in the NuGet team labels Jun 13, 2023
@nkolev92 nkolev92 modified the milestone: .NET 8.0 Jun 13, 2023
@nkolev92
Copy link
Member

The issue was not referenced via a fixes statement so it wasn't closed. I've amended the PR body.

Closing this as completed.

@nkolev92 nkolev92 added this to the 6.7 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs (and linked Issues) created by someone not in the NuGet team PerfWins Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants