Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static graph restore doesn't restore packages.config only solution #13109

Closed
zivkan opened this issue Dec 26, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5561
Closed

Static graph restore doesn't restore packages.config only solution #13109

zivkan opened this issue Dec 26, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5561
Assignees
@zivkan
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Milestone
6.10

Comments

@zivkan
Copy link
Member

zivkan commented Dec 26, 2023 •
edited
Loading

NuGet Product Used

MSBuild.exe

Product Version

all

Worked before?

No response

Impact

None

Repro Steps & Context

Have a solution with only packages.config projects. msbuild -t:restore -p:RestorePackagesConfig=true will successfully restore the packages.config packages, but msbuild -t:restore -pRestorePackagesConfig=true -p:RestoreUseStaticGraphEvaluation=true will not.

staticRestorePC.zip

I think it's caused by NuGet/NuGet.Client#3116 edit: it was not

Previously, MSBuild's static graph API could have evaluated the MSBuild script, but since that PR, a target needs to be executed to populate the RestoreProjectStyle MSBuild property.

Verbose Logs

No response
This was referenced Dec 26, 2023
Merged
Merged
@zivkan zivkan self-assigned this Dec 27, 2023
@zivkan zivkan added Functionality:Restore Area:RestoreStaticGraph Issues related to the Static Graph restore Priority:2 Issues for the current backlog. and removed Triage:Untriaged labels Dec 27, 2023
@zivkan zivkan changed the title Static graph restore doesn't restore packages.config projects Static graph restore doesn't restore packages.config only solution Dec 27, 2023
@kartheekp-ms kartheekp-ms added this to the 6.10 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
6.10
Development

Successfully merging a pull request may close this issue.

Static graph restore should work with packages.config only solution NuGet/NuGet.Client
2 participants
@zivkan @kartheekp-ms