Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to CompareTo and Equals should not allocate #13442

Closed
Erarndt opened this issue May 14, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#5799
Closed

Calls to CompareTo and Equals should not allocate #13442

Erarndt opened this issue May 14, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#5799
Assignees
Labels
PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug

Comments

@Erarndt
Copy link

Erarndt commented May 14, 2024

In the FrameworkDependency, the CompareTo and Equals calls end up boxing the FrameworkDependencyFlags property. It's not a huge number of allocations (~2MB for OrchardCore), but they're easy to avoid

image

Copy link
Contributor

@Erarndt Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label May 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label May 16, 2024
@kartheekp-ms kartheekp-ms added Tenet:Performance Performance issues PerfWins missing-required-type The required type label is missing. labels May 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label May 16, 2024
@jeffkl jeffkl added the Priority:2 Issues for the current backlog. label May 16, 2024
@jeffkl jeffkl self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants