Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocation: nuget.protocol.dll!NuGet.Protocol.HttpCacheUtility+<CreateCacheFileAsync>d__.MoveNext|nuget.protocol.dll!NuGet.Protocol.PackageDependencyGroupConverter.ReadJson #13445

Open
nkolev92 opened this issue May 16, 2024 · 1 comment
Open

allocation: nuget.protocol.dll!NuGet.Protocol.HttpCacheUtility+<CreateCacheFileAsync>d__.MoveNext|nuget.protocol.dll!NuGet.Protocol.PackageDependencyGroupConverter.ReadJson #13445

nkolev92 opened this issue May 16, 2024 · 1 comment
Assignees
@martinrrm
Labels
Area:Protocol Client/Server protocol /code around it Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:Performance Performance issues Type:Bug

Comments

@nkolev92
Copy link
Member

Internal issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1864821
Code in:

Some ideas: https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Protocol/Converters/PackageDependencyGroupConverter.cs

  • Avoid using LoadJson, iterate by token.
  • Intern the dependency groups /deduplicate
  • Ensure GetShortFolderName is not computed continously. The framework parsing tends to be cached, but another ideas to cache that as well.
@nkolev92 nkolev92 added Product:VS.Client Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Area:Protocol Client/Server protocol /code around it Category:Quality Week Issues that should be considered for quality week labels May 16, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label May 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label May 17, 2024
@nkolev92 nkolev92 added Priority:1 High priority issues that must be resolved in the current sprint. and removed Priority:2 Issues for the current backlog. labels May 23, 2024
@martinrrm martinrrm self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinrrm martinrrm

Labels
Area:Protocol Client/Server protocol /code around it Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkolev92 @martinrrm