Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak wording of NU1603 #13446

Open
danmoseley opened this issue May 16, 2024 · 0 comments · May be fixed by NuGet/NuGet.Client#5812
Open

tweak wording of NU1603 #13446

danmoseley opened this issue May 16, 2024 · 0 comments · May be fixed by NuGet/NuGet.Client#5812
Labels
Category:Quality Week Issues that should be considered for quality week help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Feature

Comments

@danmoseley
Copy link

danmoseley commented May 16, 2024 •
edited

NuGet Product(s) Involved

Other/NA

The Elevator Pitch

I got a bunch of these and was a little confused
[restore] .../TestProject.IntegrationServiceA.csproj : error NU1603: Warning As Error: TestProject.IntegrationServiceA depends on Aspire.StackExchange.Redis (>= 8.0.0) but Aspire.StackExchange.Redis 8.0.0 was not found. An approximate best match of Aspire.StackExchange.Redis 8.0.1 was resolved. [...]

How i read it

  • "any version 8.0.0 or later is acceptable, but we had to fall back and use 8.0.1"
    this confused me as 8.0.1 seems to match the >= constraint so how was it approximate?

What it's saying

  • "any version 8.0.0 or later is acceptable, with 8.0.0 preferred. We could not find 8.0.0 so we used the next closest version we found 8.0.1"

Maybe the message would be clearer like
TestProject.IntegrationServiceA depends on Aspire.StackExchange.Redis (>= 8.0.0). Aspire.StackExchange.Redis 8.0.0 was preferred but not found. The next nearest available match Aspire.StackExchange.Redis 8.0.1 was resolved.

Additional Context and Details

No response
@danmoseley danmoseley mentioned this issue May 16, 2024
Merged
@jeffkl jeffkl added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. help wanted Considered good issues for community contributions. Triage:NeedsTriageDiscussion and removed Triage:Untriaged labels May 17, 2024
@jebriede jebriede added Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. and removed Triage:NeedsTriageDiscussion Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels May 20, 2024
@JonDouglas JonDouglas linked a pull request May 20, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Quality Week Issues that should be considered for quality week help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wording of NU1603 and related strings NuGet/NuGet.Client
3 participants
@danmoseley @jebriede @jeffkl