Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet nomination code causes unnecessary allocations #13449

Open
zivkan opened this issue May 18, 2024 · 0 comments
Open

NuGet nomination code causes unnecessary allocations #13449

zivkan opened this issue May 18, 2024 · 0 comments

Comments

@zivkan
Copy link
Member

zivkan commented May 18, 2024

Check VsSolutionRestoreService and VSNominationUtilities for inappropriate usage of LINQ, particularly examples like:

https://github.com/NuGet/NuGet.Client/blob/f702fc3dc44e17a0666dea01e9aa18c5c1175b27/src/NuGet.Clients/NuGet.SolutionRestoreManager/VsSolutionRestoreService.cs#L295-L298

Collections should be created with the correct initial capacity to avoid risk of resizing.

anonymous lamba functions cause allocations too, which can be avoided with for loops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@zivkan and others