Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attributes to control nuget dependencies break the project properties tab #1831

Closed
jmelosegui opened this issue Dec 14, 2015 · 18 comments
Assignees
Labels
Resolution:External This issue appears to be External to nuget Type:Bug
Milestone

Comments

@jmelosegui
Copy link

Having the following solution structure.

image

I want to propagate the StyleCop.Analyzers package to all the project depending on ClassLibrary5. So I created the following project.json file.

{
  "supports": { },
  "dependencies": {
    "StyleCop.Analyzers": {
      "version": "1.0.0-rc2",
      "suppressParent": "none"
    }
  },
  "frameworks": {
    ".NETPortable,Version=v4.5,Profile=Profile111": { }
  }
}

After adding the StyleCop.Analyzers and specifying a json object as a value

{
  "version": "1.0.0-rc2",
  "suppressParent": "none"
}

Any project referencing the ClassLibrary5 project will have a the warning

The project 'ClassLibrary5' cannot be referenced.           

and the property windows for ClassLibrary5 project will show the following error

image

As soon as I modify the project.json file to.

{
  "supports": { },
  "dependencies": {
    "StyleCop.Analyzers": "1.0.0-rc2"
  },
  "frameworks": {
    ".NETPortable,Version=v4.5,Profile=Profile111": { }
  }
}

(Notice the dependency value is a string value and not a json object) everything started working again but nuget dependecies do not propagate any more and I have to explicitly add the package in every project in my solution.

Visual Studio version: 14.0.24720.00 Update 1
NuGet Package Manager version: 3.3.0

@AArnott
Copy link
Contributor

AArnott commented Dec 14, 2015

I suspect this is actually a bug owned by the C#/VB project system team. @jasonmalinowski, can you confirm?

@jasonmalinowski
Copy link
Member

I'm not sure. I cannot imagine any path where the app designer would fail to load because of an JSON parsing issue...somebody is just going to have to debug this one.

@yishaigalatzer
Copy link

Trying to find the owner of this area.

CC @emgarten @Pilchie

@Pilchie
Copy link

Pilchie commented Dec 14, 2015

Is classlibrary5 (the one where the app designer fails), a portable library? cc @rchande

@yishaigalatzer
Copy link

The picture says it is

@Pilchie
Copy link

Pilchie commented Dec 14, 2015

Also, is this on VS2015 RTM or Update1? I thought @rchande fixed something to do with unrecognized schema stuff in Portable as part of U1.

@Pilchie
Copy link

Pilchie commented Dec 19, 2015

@jmelosegui do you have Visual Studio Update 1 installed? If not, can you try installing it and see if this still repros?

@jmelosegui
Copy link
Author

Yes I do. Please, read the end of the original post.

@Pilchie
Copy link

Pilchie commented Dec 19, 2015

Sorry for missing that. @rchande can you take a look at the project properties issue?

@jasonmalinowski can you look at "Any project referencing the ClassLibrary5 project will have a the warning: The project 'ClassLibrary5' cannot be referenced."?

@yishaigalatzer / @emgarten / @davidfowl : what is suppressParent and how does it affect the lock file?

@AArnott
Copy link
Contributor

AArnott commented Dec 19, 2015

@Pilchie you can read about suppressParent here

@Pilchie
Copy link

Pilchie commented Dec 19, 2015

Okay, but flowing the dependency transitively is the default, so the entry shouldn't be needed for @jmelosegui's scenario.

@AArnott
Copy link
Contributor

AArnott commented Dec 19, 2015

Fair enough. But I am seeing all the same symptoms, he is seeing for my project where I do you have to specify that extra dependency data.

@jasonmalinowski
Copy link
Member

@Pilchie: as far as triaging this, who should be assigned first? It's quite possible all the various symptoms were seeing here are from some root cause.

@yishaigalatzer
Copy link

@Pilchie ping. I'm assigning to @jasonmalinowski as a rep for your team for now. But I don't necessarily expect him to do the work, just a way to put the monkey on someone's shoulder 😈

@rchande
Copy link

rchande commented Jan 15, 2016

@yishaigalatzer @jasonmalinowski I have a DevDiv internal bug assigned to me about this.

@rrelyea
Copy link
Contributor

rrelyea commented Jun 10, 2016

@rchande - can you share bug status and number, please?

@rrelyea
Copy link
Contributor

rrelyea commented Dec 8, 2016

@rchande - just sent email to follow up.

@nkolev92
Copy link
Member

@rrelyea Did you find the bug status and number here?

Closing it as external.

@nkolev92 nkolev92 added the Resolution:External This issue appears to be External to nuget label Feb 22, 2018
@nkolev92 nkolev92 added this to the 4.7 milestone Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution:External This issue appears to be External to nuget Type:Bug
Projects
None yet
Development

No branches or pull requests

8 participants