Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageReference PrivateAssets are added to @(ReferenceCopyLocalPaths) #5908

Closed
AlexEyler opened this issue Sep 20, 2017 · 2 comments
Closed
Labels
Resolution:Question This issues appears to be a question, not a product defect Style:PackageReference

Comments

@AlexEyler
Copy link

AlexEyler commented Sep 20, 2017

Please read the following information before posting the issue.

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): msbuild

Detailed repro steps so we can see the same problem

  1. Create a new .NET Framework project (ex: CSharp class library)
  2. Add a PackageReference to the project
  3. Set the PackageReference to include PrivateAssets="true"
  4. Build (preferably with /bl to view the log)
    Expected: @(ReferenceCopyLocalPaths) contains no elements after the ResolveAssemblyReferences target is completed.
    Actual: @(ReferenceCopyLocalPaths) contains the package reference DLL.

Here are the logs from a build using the repro steps: msbuild-netfx.zip

Notes:

  • This does not repro in a netcore or netstandard project.
  • I'm not sure if this is the expected behavior. However, the VSSDK needs a way for users to specify that a DLL referenced from a PackageReference should not be included in a VSIX.
@nkolev92
Copy link
Member

@rohit21agrawal you had some context here?

@rohit21agrawal
Copy link
Contributor

@AlexEyler you can achieve desired behavior by ExcludeAssets="runtime"

@rohit21agrawal rohit21agrawal added Resolution:Question This issues appears to be a question, not a product defect Style:PackageReference labels Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution:Question This issues appears to be a question, not a product defect Style:PackageReference
Projects
None yet
Development

No branches or pull requests

3 participants