NuGet restore fails with .NET452 -> UAP ref (valid for UWP designer) #5915

clairernovotny · 2017-09-21T15:26:41Z

@dotMorten has been trying to implement designers for the UWP Toolkit controls. The pattern here is that the designer project is .NET Framework project that references a UWP control library project. This seems to fail with PackageReference:

https://github.com/Microsoft/UWPCommunityToolkit/commits/dotMorten/DesignAssembly

This was from the above branch calling msbuild /t:restore on the design project. This is a blocker for the toolkit… any workarounds?

"C:\dev\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Design\Microsoft.Toolkit.Uwp.UI.Controls.Design.csproj" (restore target) (1) ->
(Restore target) ->
  C:\dev\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Design\Microsoft.Toolkit.Uwp.UI.Controls.Design.csproj : error NU1201: Project
Microsoft.Toolkit.Uwp.UI.Controls is not compatible with net452 (.NETFramework,Version=v4.5.2). Project Microsoft.Toolkit.Uwp.UI.Controls su
pports: uap10.0 (UAP,Version=v10.0)
  C:\dev\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Design\Microsoft.Toolkit.Uwp.UI.Controls.Design.csproj : error NU1201: Project
Microsoft.Toolkit.Uwp.UI.Controls is not compatible with net452 (.NETFramework,Version=v4.5.2) / win. Project Microsoft.Toolkit.Uwp.UI.Contr
ols supports: uap10.0 (UAP,Version=v10.0)
  C:\dev\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Design\Microsoft.Toolkit.Uwp.UI.Controls.Design.csproj : error NU1201: Project
Microsoft.Toolkit.Uwp.UI.Controls is not compatible with net452 (.NETFramework,Version=v4.5.2) / win-x64. Project Microsoft.Toolkit.Uwp.UI.C
ontrols supports: uap10.0 (UAP,Version=v10.0)
  C:\dev\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Design\Microsoft.Toolkit.Uwp.UI.Controls.Design.csproj : error NU1201: Project
Microsoft.Toolkit.Uwp.UI.Controls is not compatible with net452 (.NETFramework,Version=v4.5.2) / win-x86. Project Microsoft.Toolkit.Uwp.UI.C
ontrols supports: uap10.0 (UAP,Version=v10.0)

    0 Warning(s)
    4 Error(s)

The text was updated successfully, but these errors were encountered:

rrelyea · 2017-09-21T17:54:15Z

@rohit21agrawal is doing some initial investigation here.

rohit21agrawal · 2017-09-21T18:32:24Z

@dotMorten @onovotny the issue here is that NuGet has never checked for Project Reference compatibility in the packages.config world but it does so in the PackageReference world - which is what you are seeing. a net452 -> uap10.0 reference is incompatible.

Even with the packages.config workaround, are you able to build your project? I would be surprised if you are able to.

clairernovotny · 2017-09-21T18:51:30Z

@rohit21agrawal Yes, this is how the UWP design-time assemblies are built.

rohit21agrawal · 2017-09-21T19:15:26Z

not sure what NuGet can do here. if we stop looking at compat between project references, apart from violating package-project duality , we will also not be able to flow dependencies transitively since we won't know what's compatible with what.

rohit21agrawal · 2017-09-21T19:15:42Z

let me discuss more in detail with @emgarten and @rrelyea and give an update.

dotMorten · 2017-09-21T22:03:52Z

How about being able to define an explicit opt-out in the package reference?

rohit21agrawal · 2017-09-21T22:20:17Z

could you elaborate more? are you talking about opting-out of compatibility check for P2P references?

dotMorten · 2017-09-21T22:26:30Z

Yeah something along the lines of this:

<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" CompatibilityCheck="False">
   <Version>5.4.0</Version>
</PackageReference>

...or a platform override:

<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" ForceTargetPlatform="uap10.0">
   <Version>5.4.0</Version>
</PackageReference>

emgarten · 2017-09-21T22:58:49Z

I suggest adding a ValidateFrameworkCompatibility property to disable TFM checks for everything. This would match the ValidateRuntimeIdentifierCompatibility property that exists today for RID checks.

<PropertyGroup>
  <ValidateFrameworkCompatibility>false</ValidateFrameworkCompatibility>
</PropertyGroup>

Having this option on a per item basis requires a resolving conflicting settings across the dependency graph. For example if a package has compat turned off it makes sense that the transitive dependencies are also ignored, but if another package has the same dependencies it isn't obvious how those are treated.

The same applies to turning off compat only for projects or only for packages. If compat it ignored for a project then the transitive package dependencies from that project would also need to be ignored since they could be meant for an incompatible TFM, and the same thing as above occurs again.

For that reason I think this should be a simple on/off. If you need to do custom things that require breaking basic compat rules you can disable the checks but need to be very careful to avoid runtime problems that could result.

clairernovotny · 2017-09-22T00:09:36Z

I'll absolutely admit this is an edge-case and could/should require some kind of property to override default settings and enable this.

dotMorten · 2017-09-22T00:20:25Z

I worked around it by using a good old assembly reference instead of a project reference. Not pretty but it unblocks us

rrelyea · 2017-09-22T00:30:17Z

I like the <Reference /> solution.

Given that this is a very rare scenario, I'd prefer to minimize investment in this area. When @rohit21agrawal, @emgarten and I are all in the same place at the same time, we'll discuss the options a bit...

rohit21agrawal · 2017-09-22T23:12:28Z

@onovotny @dotMorten there is one more work around that could potentially make this work if you want to give this a try:

 <ProjectReference Include="..\Microsoft.Toolkit.Uwp.UI.Controls\Microsoft.Toolkit.Uwp.UI.Controls.csproj" Condition="'$(ExcludeRestorePackageImports)' != 'true'">
      <Project>{e9faabfb-d726-42c1-83c1-cb46a29fea81}</Project>
      <Name>Microsoft.Toolkit.Uwp.UI.Controls</Name>
      <Private>False</Private>
    </ProjectReference>

Let me know if this works for you.

rrelyea · 2017-09-25T21:41:29Z

Yes, we aren't planning more work here. Using a ProjectReference with Condition="'$(ExcludeRestorePackageImports)' != 'true'" is probably the most elegant way to make project reference be ignored by NuGet restore.

dotMorten · 2017-10-11T19:18:36Z

@rrelyea @rohit21agrawal @emgarten Thanks for all the suggestions. Just circling back now.
ValidateFrameworkCompatibility works great for getting rid of the reference warnings inside Visual Studio.
The project reference with ExcludeRestorePackageImports didn't work for me, but that's ok - I can use a direct assembly reference.

However, the bad news is none of that works when building from the commandline. I'm still getting compile time errors there.

msbuild /t:build "UWP Community Toolkit.sln" /p:Configuration=Release /p:Platform="Any CPU"

Branch is updated with my changes: https://github.com/Microsoft/UWPCommunityToolkit/compare/dotMorten/DesignAssembly

rohit21agrawal · 2017-10-11T19:21:19Z

it looks like SDK is doing TFM compatibility check too. @nguerrera @dsplaisted any ideas?

dsplaisted · 2017-10-11T19:29:58Z

Yes, the SDK does TFM compatibility checks, and with dotnet/msbuild#2595 MSBuild will be doing them instead.

clairernovotny · 2017-10-11T19:31:51Z

This is a blocker as a .NET -> UWP reference is valid for the purpose of creating designer controls.

dotMorten · 2017-10-11T19:31:56Z

@dsplaisted Is there any workaround we can do so the UWP toolkit can get design-time assembly support checked in?

rohit21agrawal · 2017-10-11T19:36:17Z

also, @dotMorten i am interested in knowing why ProjectReference didn't work for you with ExcludeRestorePackageImports set? can you show the restore errors you got there?

dotMorten · 2017-10-11T19:41:03Z

@rohit21agrawal The project reference with ExcludeRestorePackageImports wouldn't even allow me to build from within Visual Studio:
1>C:\Program Files\dotnet\sdk\2.0.2\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.Common.targets(87,5): error : Project 'C:\GitHub\Microsoft\UWPCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls\Microsoft.Toolkit.Uwp.UI.Controls.csproj' targets 'UAP,Version=v10.0'. It cannot be referenced by a project that targets '.NETFramework,Version=v4.5.2'.

...and that is with ValidateFrameworkCompatibility set to false.

rohit21agrawal · 2017-10-11T19:43:18Z

CC: @unniravindranathan - the workaround that nuget provided is potentially going to be unusable if SDK (and eventually msbuild) is going to be doing compatibility checks as well.

@dsplaisted is there a way to opt out of compatibility check that SDK (and eventually msbuild ) does?

dsplaisted · 2017-10-11T21:30:41Z

Looking at the MSBuild code, I think you can set the metadata SkipGetTargetFrameworkProperties="true" on the ProjectReference, and I think this will work both before and after the compatibility check moves to MSBuild.

dotMorten · 2017-10-11T22:56:50Z

@dsplaisted You're a friggin superhero! It even makes the project reference work!

rohit21agrawal · 2017-10-11T23:06:19Z

awesome! glad this is resovled! Thanks @dsplaisted

rrelyea assigned rohit21agrawal Sep 21, 2017

rrelyea added Functionality:Restore Triage:Investigate labels Sep 21, 2017

rrelyea closed this as completed Sep 25, 2017

rrelyea added the Resolution:Question This issues appears to be a question, not a product defect label Sep 25, 2017

rrelyea added this to the 4.4 milestone Sep 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NuGet restore fails with .NET452 -> UAP ref (valid for UWP designer) #5915

NuGet restore fails with .NET452 -> UAP ref (valid for UWP designer) #5915

clairernovotny commented Sep 21, 2017 •

edited

rrelyea commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

clairernovotny commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

dotMorten commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

dotMorten commented Sep 21, 2017 •

edited

emgarten commented Sep 21, 2017

clairernovotny commented Sep 22, 2017

dotMorten commented Sep 22, 2017

rrelyea commented Sep 22, 2017

rohit21agrawal commented Sep 22, 2017

rrelyea commented Sep 25, 2017

dotMorten commented Oct 11, 2017 •

edited

rohit21agrawal commented Oct 11, 2017

dsplaisted commented Oct 11, 2017

clairernovotny commented Oct 11, 2017

dotMorten commented Oct 11, 2017

rohit21agrawal commented Oct 11, 2017

dotMorten commented Oct 11, 2017 •

edited

rohit21agrawal commented Oct 11, 2017

dsplaisted commented Oct 11, 2017

dotMorten commented Oct 11, 2017

rohit21agrawal commented Oct 11, 2017

NuGet restore fails with .NET452 -> UAP ref (valid for UWP designer) #5915

NuGet restore fails with .NET452 -> UAP ref (valid for UWP designer) #5915

Comments

clairernovotny commented Sep 21, 2017 • edited

rrelyea commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

clairernovotny commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

dotMorten commented Sep 21, 2017

rohit21agrawal commented Sep 21, 2017

dotMorten commented Sep 21, 2017 • edited

emgarten commented Sep 21, 2017

clairernovotny commented Sep 22, 2017

dotMorten commented Sep 22, 2017

rrelyea commented Sep 22, 2017

rohit21agrawal commented Sep 22, 2017

rrelyea commented Sep 25, 2017

dotMorten commented Oct 11, 2017 • edited

rohit21agrawal commented Oct 11, 2017

dsplaisted commented Oct 11, 2017

clairernovotny commented Oct 11, 2017

dotMorten commented Oct 11, 2017

rohit21agrawal commented Oct 11, 2017

dotMorten commented Oct 11, 2017 • edited

rohit21agrawal commented Oct 11, 2017

dsplaisted commented Oct 11, 2017

dotMorten commented Oct 11, 2017

rohit21agrawal commented Oct 11, 2017

clairernovotny commented Sep 21, 2017 •

edited

dotMorten commented Sep 21, 2017 •

edited

dotMorten commented Oct 11, 2017 •

edited

dotMorten commented Oct 11, 2017 •

edited