Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet client code needs some refactoring #7207

Closed
2 tasks
jainaashish opened this issue Aug 15, 2018 · 2 comments
Closed
2 tasks

NuGet client code needs some refactoring #7207

jainaashish opened this issue Aug 15, 2018 · 2 comments
Labels
Priority:2 Issues for the current backlog. Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Milestone

Comments

@jainaashish
Copy link
Contributor

Multiple places in current NuGet code needs refactoring to better align with their meaning. Currently they are poorly named or explained or designed. This is the uber issue to keep track of such instances and look for the opportunity to improve those in future releases.

  • LockFile which has nothing to do with a lock file instead represent assets file (project.assets.json or project.lock.json)

  • PackageSpec which again has nothing to do with a package instead it's kind of projectSpec or all the relevant details about the project NuGet needs for restore

@NuGet/nuget-client please keep on adding more n more such instances here.

@jainaashish jainaashish added the Type:Engineering product/infrastructure work/not a customer bug/feature/DCR label Aug 15, 2018
@aidapsibr
Copy link

aidapsibr commented Aug 18, 2018

I also would like to recommend facades. The code is incredibly hard to reason about and harder still to use all the constituent parts correctly to end up in "default" behavior. If this is not in line with the spirit of the issue feel free to thumbs down. 😅

@jainaashish jainaashish added this to the 5.0 milestone Aug 30, 2018
@jainaashish jainaashish added the Priority:2 Issues for the current backlog. label Aug 30, 2018
@DoRonMotter DoRonMotter modified the milestones: 5.0, Backlog Jan 31, 2019
@nkolev92
Copy link
Member

Unlikely to make these binary breaking changes at this point. We can easily reopen an issue if we decide to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Projects
None yet
Development

No branches or pull requests

5 participants