Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing: implement dotnet trusted-signers command #8053

Closed
heng-liu opened this issue Apr 23, 2019 · 7 comments · Fixed by NuGet/NuGet.Client#3989
Closed

Signing: implement dotnet trusted-signers command #8053

heng-liu opened this issue Apr 23, 2019 · 7 comments · Fixed by NuGet/NuGet.Client#3989
Assignees
Labels

Comments

@heng-liu
Copy link
Contributor

heng-liu commented Apr 23, 2019

Implement "dotnet trusted-signers" command according to NuGet.exe command "nuget trusted-signers".+
Spec is here" #10628

@heng-liu heng-liu added this to the 5.1 milestone Apr 23, 2019
@heng-liu heng-liu self-assigned this Apr 23, 2019
@rrelyea rrelyea modified the milestones: 5.1, 5.2 Apr 30, 2019
@zivkan zivkan modified the milestones: 5.2, 5.3 Jul 1, 2019
@rrelyea rrelyea modified the milestones: 5.3, Backlog Aug 12, 2019
@zkat zkat added the Priority:2 Issues for the current backlog. label Feb 25, 2020
@heng-liu heng-liu added this to the Sprint 183 - 2021.02.01 milestone Feb 1, 2021
@heng-liu heng-liu self-assigned this Feb 1, 2021
@aortiz-msft aortiz-msft removed this from the Sprint 183 - 2021.02.01 milestone Feb 1, 2021
@aortiz-msft aortiz-msft assigned erdembayar and unassigned heng-liu Feb 26, 2021
@aortiz-msft aortiz-msft added this to the Sprint 2021-03 milestone Feb 26, 2021
@erdembayar
Copy link
Contributor

@heng-liu
Is there spec for "nuget trusted-signers"? If not I just look at what "nuget trusted-signers" does and make parity with it would be enough for this issue?

@heng-liu
Copy link
Contributor Author

@erdembayar
Copy link
Contributor

erdembayar commented Mar 1, 2021

@heng-liu @dtivel @nkolev92
Can I get some context? Where do I implement it? Is it in NuGet.Client repo or dotnet repo?

@heng-liu
Copy link
Contributor Author

heng-liu commented Mar 1, 2021

Hi @erdembayar, the nuget.exe trusted-signers command is already implemented. This is to parity dotnet CLI with nuget.exe.
You may take nuget.exe verify command and dotnet nuget verify command as an example.
We implemented verify command for dotnet under src\NuGet.Core\NuGet.CommandLine.XPlat\Commands\Signing\VerifyCommand.cs

@erdembayar
Copy link
Contributor

@aortiz-msft @heng-liu @zkat @kartheekp-ms
It looks spec for dotnet nuget trusted-signer not done due to complexity mentioned here. Do I need to create spec first and confirm with dotnet team first or not?

@kartheekp-ms
Copy link
Contributor

kartheekp-ms commented Mar 2, 2021

@erdembayar - nuget.exe trusted-signers command spec is archived here. Hope this helps you to create a spec for the new dotnet command.

@nkolev92
Copy link
Member

nkolev92 commented Mar 2, 2021

@erdembayar Remember to follow https://github.com/NuGet/NuGet.Client/blob/dev/docs/feature-guide.md for the process.

You will probably need to update the template sued in the spec that @kartheekp-ms linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants