Same project reference names have different casings in packages lock file

[v-luzh]

Details about Problem

NuGet version: NuGet Client Dev\5.4.0.6233
VS Version: Master\29311.58
OS: Windows-10-Enterprise-19H1-04-05-2019

Detailed repro steps

1. Create a solution with three .NET Core Class Library projects (named Lib1/Lib2/Lib3), make the project graph structure: Lib1 -> Lib2 -> Lib3 through “Add reference” context menu in Solution Explorer.
2. Set property “RestorePackagesWithLockFile” to true in csproj file of Lib1.
3. Restore the solution and look at the generated lock file “packages.lock.json”.

Expected

Same project reference names should have the same casings in lock file.

Actual

Same project reference names have different casings in lock file as below screenshot.

Note

It started to repro from fixing of the bug 7840.

[zivkan]

Point of clarification, the fact that the case is different in the file isn't really a concern (in my opinion at least). The issue is that restoring without the project changing can cause the lock file to change, just as in #7840.

[rrelyea]

@zivkan - i'm unclear with what we should do based on your statement. Is this good or bad behavior in the lock file? Why?

[zivkan]

We should change the Lib3 that's listed as lib2's dependency to lowercase, so that the lock file doesn't change case in the following reproduction:

(cd to an empty directory)
dotnet new sln
dotnet new classlib -n ProjA
dotnet new classlib -n ProjB
dotnet new classlib -n ProjC
dotnet sln add proja\proja.csproj
dotnet sln add projb\projb.csproj
dotnet sln add projc\projc.csproj
dotnet add ProjA\ProjA.csproj reference PROJB\PROJB.csproj
dotnet add ProjB\ProjB.csproj reference PROJC\PROJC.csproj
echo '' > ProjA\packages.lock.json
dotnet restore –force-evaluate
copy ProjA\packages.lock.json ProjA\packages.lock.json.bak
dotnet restore –force-evaluate ProjA\ProjA.csproj
git diff ProjA\packages.lock.json ProjA\packages.lock.json.bak

[heng-liu]

Hi @nkolev92 , as @erdembayar and I are checking compatibility issues, may I know if the case change in the lock.json file will cause compatibility issue? Thanks!

[nkolev92]

No, this is an old issue.

[AlexKeySmith]

Could this result in a NU1004 error? I'm attempting to diagnose why project A by itself restores ok, but when it is referenced by project B, then project A is reported as having changed dependencies. This is in dotnet 5.0.302

[nkolev92]

@AlexKeySmith

Afaik, it shouldn't.

Would you mind creating an issue that we could have someone validate?

[AlexKeySmith]

Thanks @nkolev92 I realised my issue in the end was: #8465 but thanks for the response.