Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate DiagnosticsSource for protocol diagnostics #8784

Closed
zivkan opened this issue Oct 31, 2019 · 1 comment
Closed

Investigate DiagnosticsSource for protocol diagnostics #8784

zivkan opened this issue Oct 31, 2019 · 1 comment
Labels
Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Type:Feature

Comments

@zivkan
Copy link
Member

zivkan commented Oct 31, 2019

System.Net.Http.HttpClient emits events though DiagnosticSource: https://github.com/dotnet/corefx/blob/master/src/System.Net.Http/src/HttpDiagnosticsGuide.md

Note, it works on both .NET Framework and .NET Core, but the event names are different (probably because the event datastructure is different), so if we use it, it's important to test both runtimes. Also, check what happens on mono.

This will let us get much more detailed information, if we want it, but depending on what we want, it might also not give us the level of information we want.

@zivkan zivkan added Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org labels Oct 31, 2019
@zivkan
Copy link
Member Author

zivkan commented Dec 9, 2019

From my investigations, it's not a good fit. One of the only advantages it has is that it's a single place to receive request completion and request error notifications. However, the differences between how the .NET Framework and .NET Core versions work increase the complexity, particularly when the request failed. It's simpler to use an exception handler, as HttpRetryHandler already does.

@zivkan zivkan closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Type:Feature
Projects
None yet
Development

No branches or pull requests

2 participants