This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Varios minor improvements #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had a complicated dependency between the VSIX and the build tasks so that we could build both as a project reference during command line builds, but have a project reference at design-time. There wasn't in the end much value in having the Tasks project in the VSIX solution, in fact, the contrary, since the tasks is backwards compatible with VS2015, whereas the VSIX targets VS2017 exclusively and therefore has incompatible MSBuild nuget package dependencies. By removing the project reference and simplifying the command line build, we just require the build to exist (building once the Build solution or build.cmd), we remove the complexity and make it easier to maintain moving forward. The restore has also switched to using MSBuild built-in restore capability, instead of using nuget.exe for projects.
This should make it easier to diagnose failed unit tests on CI, instead of having just a simple [FAIL] like we do now.
kzu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to VS2017 AppVeyor image and update nugets to latest stable versions