Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Add workaround for Xamarin.Android 9.4 #172

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

mrward
Copy link
Member

@mrward mrward commented Jul 9, 2019

When building a .nuproj project that referenced a Xamarin.Android
project _GetReferencedPackageContents would fail when
Xamarin.Android 9.4 was installed with the error:

The "FilterAssemblies" task was not given a value for the required
parameter "DesignTimeBuild".

To workaround this the DesignTimeBuild property is set, if not already,
and passed to the GetPackageContents.

@kzu
Copy link
Contributor

kzu commented Jul 9, 2019

I think this should be fixed upstream in XA

Copy link
Contributor

@kzu kzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it's fine if we always pass false here, since building and collecting package content is never a DTB operation. I wouldn't set the property, I'd just pass a hardcoded value down instead

When building a .nuproj project that referenced a Xamarin.Android
project _GetReferencedPackageContents would fail when
Xamarin.Android 9.4 was installed with the error:

    The "FilterAssemblies" task was not given a value for the required
    parameter "DesignTimeBuild".

To workaround this the DesignTimeBuild property is set to false
when GetPackageContents is called for each project.
@mrward
Copy link
Member Author

mrward commented Jul 10, 2019

Updated to just set a hard coded value of false for DesignTimeBuild.

@kzu kzu merged commit 133ccf9 into NuGet:dev Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants