This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Avoid SxS issues with NuGet tasks by IL merging #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a build, it's possible that a different version of the NuGet assemblies are loaded by the MSBuild process (i.e. from the MSBuild extensions path), potentially causing this package to break. So instead of including the NuGet (and Newtonsoft.Json) assemblies as external references, we merge them with the main tasks assemblies, thereby isolating our tasks from those deps and ensuring that the targets will behave as tested and shipped regardless of the installed version of NuGet.
adalon
approved these changes
Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a build, it's possible that a different version of the NuGet
assemblies are loaded by the MSBuild process (i.e. from the MSBuild
extensions path), potentially causing this package to break.
So instead of including the NuGet (and Newtonsoft.Json) assemblies
as external references, we merge them with the main tasks assemblies,
thereby isolating our tasks from those deps and ensuring that the
targets will behave as tested and shipped regardless of the installed
version of NuGet.