Read RestoreProjectStyle MSBuild property once for all the NuGet project providers #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emgarten
approved these changes
Jan 5, 2017
| } | ||
| } | ||
|
|
||
| return output; |
There was a problem hiding this comment.
Trim whitespace before returning (unless you know IVsBuildPropertyStorage will always do this
There was a problem hiding this comment.
IVsBuildPropertyStorage will always trim before returning.
jainaashish
force-pushed
the
asja-CreateNuGetProject
branch
from
88949af
to
821c59a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets reading MSBuild property RestoreProjectStyle which can be set to any project style in order to set that NuGet project style. So NuGet should also respect this property and create NuGet project accordingly. To have better VS performance, we read this property only once and pass to all the nuget project providers to consume.
Fixes NuGet/Home#4134
@rrelyea @emgarten @alpaix @zhili1208 @rohit21agrawal @mishra14