Adding development dependency support for PackageReference #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainaashish
requested review from
rohit21agrawal,
PatoBeltran,
nkolev92,
zhili1208 and
mishra14
rohit21agrawal
approved these changes
Apr 25, 2018
|
please investigate why tests didn't run/failed before you merge |
jainaashish
force-pushed
the
dev-asja-developmentDependency
branch
from
92374d4
to
3efaf6f
Compare
|
Did the change make it into any VisualStudioManager/NugetClient version? I created the issue dotnet/roslyn#28757 and would like to understand is there still the bug or I don't have the latest nuget.client. |
|
We had to pull it out from 15.7 last minute but this is currently part of VS 15.8 preview bits so you'll see it if you use 15.8 latest preview bits. Eventually it will be part of final 15.8 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the updated version of #1930 to support
developmentDependencyforPackageReference. Only change from last PR is to useExclude=Compileinstead ofExclude=Runtimewhich has also been tested with ASP.NET/ EF team.Fixes NuGet/Home#4125