Fix license link generation #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
jainaashish,
PatoBeltran,
agr,
dominoFire and
zivkan
jainaashish
approved these changes
Nov 16, 2018
agr
approved these changes
Nov 16, 2018
PatoBeltran
approved these changes
Nov 16, 2018
…m the license metadata
agr
reviewed
Nov 17, 2018
test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetPackCommandTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7515
Regression: No
If Regression then when did it last work:
If Regression then how are we preventing it in future:
Fix
Details:
The url was being incorrectly encoded when a plus was in question.
The encoding strategy by the client was inconsistent with the decoding strategy by IIS, leading to where
MITandMIT+were indistinguishable.@agr I'll provide you with a build for you to test.
Testing/Validation
Tests Added: Yes
Reason for not adding tests: It's not an "expectation change" and the test were already covering that.
Validation done: