Move credentials to core #2547
Merged
Move credentials to core #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
dominoFire,
PatoBeltran,
zivkan,
jainaashish and
heng-liu
nkolev92
force-pushed
the
dev-nkolev92-movecredentialstocore
branch
from
a294020
to
207e5fc
Compare
jainaashish
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: None
Regression: No
If Regression then when did it last work:
If Regression then how are we preventing it in future:
Fix
Details: Follow up to #2080.
Just some cleanup.
Testing/Validation
Tests Added: No
Reason for not adding tests: None needed. Cosmetic change
Validation done: