Fix the handling of custom names (AssemblyName, PackageId) in packages lock file, construction and validation. #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
nkolev92
requested review from
anangaur,
zivkan,
dtivel,
dominoFire,
donnie-msft and
heng-liu
and removed request for
anangaur
nkolev92
changed the title
dtivel
approved these changes
Apr 19, 2019
test/NuGet.Clients.Tests/NuGet.CommandLine.Test/RestoreNETCoreTest.cs
Outdated
Show resolved
Hide resolved
| projectA.Properties.Add("RestorePackagesWithLockFile", "true"); | ||
| projectB.Properties.Add("PackageId", "CustomName"); | ||
|
|
||
| //projectA.Properties.Add("RestoreLockedMode", "true"); |
zivkan
approved these changes
Apr 19, 2019
test/NuGet.Clients.Tests/NuGet.CommandLine.Test/RestoreNETCoreTest.cs
Outdated
Show resolved
Hide resolved
nkolev92
force-pushed
the
dev-nkolev92-NU1004lockFile
branch
from
8425fbd
to
c91099f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7889
Regression: No, Never worked
Fix
Details:
The comparison now uses the short project name which is what's used when writing the lock file.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: