Fix false NU1004 in LockedMode where P2P projects with ATF fail due to a bad target framework equality check #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
dominoFire,
zivkan,
dtivel,
heng-liu and
donnie-msft
|
@zivkan Reverted the unneeded change. Thanks for the pointer! |
zivkan
approved these changes
Jun 5, 2019
src/NuGet.Core/NuGet.ProjectModel/ProjectLockFile/PackagesLockFileUtilities.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8187
Regression: Yes
Fix
Details:
Our project reference and package reference info is stored in different models.
TargetFrameworkInformation and ProjectRestoreMetadataFrameworkInfo.
Both of those are target framework based, however one contains the AssetTargetFallback and the other one doesn't.
Now this could be on purpose because ATF based checks for project references were done differently.
Regardless that needs investigated and I will do it NuGet/Home#8193.
Now the fix here is to always use the base framework. Even if there is a fallback the base framework will always be the same/exact one.
//cc @bergbria @rrelyea
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: Manual + automation