Stop synthesizing owners

[jnm2]

Bug

Fixes: NuGet/Home#5134
Regression: No

Fix

Details: <owners> is no longer forced to appear when not specified.

Testing/Validation

Tests Added: Yes
Validation: Integration tests failed before fix, passed after fix

[jnm2]

Also: if you'd like me to take a different approach or fit other constraints, I'd be glad to try.

[nkolev92]

@jnm2

Thgere are bunch of failing tests 68 in total, I'll paste the class names as our CI is private.
Look at tests like:
PackCommand_ExcludesFilesOutsideRoot
PackCommand_PackageFromNuspecWithEmptyFilesTag
PackCommand_WhenPackingSymbolsPackage_ExcludesExplicitAssemblyReferences
PackCommand_WarningDependencyVersionNotSpecified
PackCommand_IncludeExcludePackageFromNuspec
PackCommand_PackIcon_HappyPath_Succeeds
PackCommand_ContentV2PackageFromNuspec
PackCommand_SemVer200_Succeeds
PackCommand_MultipleFrameworks_GeneratesPackageOnBuild

PackCommand_NewProject_AddsTitleToNuspec
Icon_HappyPath_Suceed
PackageBuilderThrowsWhenLicenseUrlIsMalformed
ReadingPackageManifestRecognizeMultipleDependenciesWithTargetFramework

Can you please take a look?
A bunch of them are null refs.

[jnm2]

@nkolev92 Right now it appears that nuspecs without an <owners> element or with an empty <owners> element do not roundtrip. Instead, the element shows up equal to the <authors> element.

Is it acceptable to make it so that nuspecs without an <owners> element do roundtrip for the first time, and that nuspecs with an empty <owners> element still don't roundtrip but they result in no <owners> element instead of resulting in an <owners> element that copies the <authors> element?

[jnm2]

I believe I've fixed all the tests you mentioned and found some more related ones to fix. Could you rerun CI and let me know?

[zivkan]

The windows functional test and mac functional test failures were the same, just on different platforms:

NuGet.CommandLine.Test.NuGetSpecCommandTests.SpecCommand_NoProjectFile
NuGet.CommandLine.Test.NuGetSpecCommandTests.SpecCommand_NoProjectFile_WithArg
NuGet.CommandLine.Test.NuGetSpecCommandTests.SpecCommand_WithProjectFile

[jnm2]

Thanks, pushed fixes for those three.

[nkolev92]

Is it acceptable to make it so that nuspecs without an element do roundtrip for the first time, and that nuspecs with an empty element still don't roundtrip but they result in no element instead of resulting in an element that copies the element?

I think it's ok. There's unfortunately no neat way to handle all this in our libraries, so this is the best we have.

[nkolev92]

@NuGet/nuget-client I'd appreciate another pair of eyes on this.

[zivkan]

Theoretically this is breaking change. Anyone with custom applications using the NuGet.Packaging package will have a change in behaviour. However, I think the risk of this breaking someone is very low, so I think it's ok. But we should be aware.

[nkolev92]

Thanks for the contribution @jnm2

Sorry for the delay, we just wanted to make sure all stakeholders were aware of this change (as I imagine you are likely aware :) )

[jnm2]

Thanks for the help!