PluginFactory should default to dotnet in the path to start a plugin if DOTNET_HOST_PATH is not set
#3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier-spinelli
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
nkolev92,
rrelyea,
zivkan and
zkat
as code owners
olivier-spinelli
changed the title
nkolev92
changed the title
dotnet in the path to start a plugin if DOTNET_HOST_PATH is not set
nkolev92
reviewed
Apr 8, 2020
nkolev92
approved these changes
Apr 8, 2020
nkolev92
reviewed
Apr 8, 2020
Using the full name `NuGet.Common.RuntimeEnvironmentHelper.IsWindows`: this avoids a `using NuGet.Common` that would be useless when `IS_DESKTOP` (and would have need a ugly `#if !IS_DESKTOP` conditional).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7438
Regression: No
Last working version:
How are we preventing it in future:
Fix
Simple fallback on "dotnet.exe" or "dotnet" when DOTNET_HOST_PATH environment variable is not defined.
Testing/Validation
Tests Added: No
Reason for not adding tests: Relying on the existing tests.