Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable per Version DownloadCount for v3 feeds #3433

Merged
merged 1 commit into from Jun 19, 2020

Conversation

campersau
Copy link
Contributor

@campersau campersau commented Jun 6, 2020

Bug

Fixes: NuGet/Home#9086
Regression: No

  • Last working version: No
  • How are we preventing it in future: Added test

Fix

Removing compatibility between v2 and v3 feeds by supporting individual versions counts in v3.
Because the workaround by using the RawSearchResourceV3 directly is now declared obsolete which is currently used in these two places which I know of:

Testing/Validation

Tests Added: Yes
Reason for not adding tests:
Validation:

@zivkan zivkan added the Community PRs created by someone not in the NuGet team label Jun 8, 2020
@nkolev92
Copy link
Member

nkolev92 commented Jun 8, 2020

Do we understand the implications of this on how the UI behaves?

I like the change, I just want to know what changes.

I'd expect the UI behaves differently when you look at the browse tab. I'd expect the download count for the latest version to be displayed instead of the total.

@chgill-MSFT, I don't know if that's of any concern.

@campersau
Copy link
Contributor Author

It looks like in VS the DownloadCount from the IPackageSearchMetadata is shown (and not the one from the VersionInfo) so this change should have no impact on that.

I also build the VS UI and it showed the same download count as before.
image

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @campersau

@zivkan zivkan merged commit eb4ed52 into NuGet:dev Jun 19, 2020
@campersau campersau deleted the v3downloadcount branch June 20, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
3 participants