-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net45 support for nuget.packaging.extraction.dll and transitive closure #3554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some source-build comments.
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Configuration/Utility/IReadOnlyCollectionUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/Signing/Utility/MarshalUtility.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can minimize the impact by reducing the number of projects that build net5 assemblies.
Might be easier to compile everything into 1 assembly.
Ideally we don't publish this on NuGet.org, that will require changing our release definition.
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging.Extraction/NuGet.Packaging.Extraction.csproj
Outdated
Show resolved
Hide resolved
@rrelyea Given that my feedback is summarized in https://github.com/NuGet/Client.Engineering/issues/461, I see no reason to wait on me here. |
src/NuGet.Core/NuGet.Packaging/Signing/Utility/CertificateUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/Signing/Utility/X509ChainHolder.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Configuration/Utility/IReadOnlyCollectionUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Configuration/Settings/Items/FileClientCertItem.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Configuration/Settings/Items/StoreClientCertItem.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Configuration/Utility/IReadOnlyCollectionUtility.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimistically approving. Request a rereview from me if there are non-trivial changes.
@rrelyea, since X509Certificate
didn't implement IDisposable
until .NET 4.6, your changes look appropriate.
…ipping paths with net45 in them
…ust build n.p.e as net45.
324b8b4
to
7d73f63
Compare
Fixes: NuGet/Home#9883 - covers motivation, etc..
Regression: No
Last working version: N/A
How are we preventing it in future: N/A
Fix
Details: see at bottom of this comment.
Testing/Validation
Tests Added: No
Reason for not adding tests: Deadline...same code base. Tracking issue to ensure proper coverage: NuGet/Home#9884
Validation: Successful CI run, VS Setup team running bits and verifying rejection of tampered packages, etc...
Details of fixes:
strategy for fixes.
new dll - nuget.packaging.extraction.csproj - mostly linked to the subset of code files from nuget.packaging that needed to pull in for compilation. pulled over copies of resx files. didn't subset those resx files.