automatic formatting #3587
Merged
automatic formatting #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
nkolev92,
rrelyea and
zivkan
as code owners
zkat
force-pushed
the
dev-zkat-reformat
branch
from
d601c21
to
fc97a4a
Compare
zivkan
previously approved these changes
Aug 19, 2020
zivkan
dismissed
their stale review
I want to see how the tool is installed before the PR is merged
zivkan
reviewed
Aug 19, 2020
zivkan
reviewed
Aug 25, 2020
There was a problem hiding this comment.
Have you tried rebasing and running locally, to make sure that nothing in that has been merged in the dev branch since you created this PR violates formatting rules, and therefore would break official CI builds?
Maybe we should use continueOnError on official builds? or skip the two tasks on official builds completely.
zkat
force-pushed
the
dev-zkat-reformat
branch
from
7ce621c
to
f9e65e1
Compare
zkat
force-pushed
the
dev-zkat-reformat
branch
from
30d9459
to
6327b5a
Compare
zivkan
approved these changes
Aug 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
dotnet formatFixes: https://github.com/NuGet/Client.Engineering/issues/487