Make ProjectNames.FromDTEProjectAsync more reliable #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/NuGet.Clients/NuGet.VisualStudio.Common/ProjectSystems/ProjectNames.cs
Show resolved
Hide resolved
zivkan
force-pushed
the
dev-zivkan-projectnames-from-dte-reliability
branch
from
8722c5c
to
8cf4d7b
Compare
nkolev92
reviewed
Dec 1, 2020
| } | ||
| } | ||
|
|
||
| projectGuid = vsSolution5.GetGuidOfProjectFile(fullName); |
There was a problem hiding this comment.
This probably needs moved to the top method instead right?
There was a problem hiding this comment.
"unique name" is usually just the relative path to the project file from the solution. Every test I've tried so far returns the exact string that's in the project file. I feel like that's probably more likely to be reliable, hence I preferred it over DTE.FullName. But which of the two is tried first doesn't really matter to me. I can change it if you prefer.
There was a problem hiding this comment.
All good as long as it's consistent.
nkolev92
approved these changes
Dec 1, 2020
| } | ||
| } | ||
|
|
||
| projectGuid = vsSolution5.GetGuidOfProjectFile(fullName); |
There was a problem hiding this comment.
All good as long as it's consistent.
kartheekp-ms
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/602
Regression: Yes
Fix
Details: EnvDTE.Project is implemented by project systems, not a generic implemented by the VS platform itself. Therefore, some project systems might have incomplete or buggy implementations. Try multiple ways to get the project GUID.
Testing/Validation
Tests Added: No
Reason for not adding tests: Problems only occurs on custom & 3rd party project systems that don't fully implement EnvDTE.Project
Validation: Need to insert into VS and monitor telemetry.