Enable Shift+Tab keyboard navigation to work beyond the PMUI Tabs #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10234
Regression: No. Despite many changes in 16.x to the tabbing, this actually has been a problem since at least 15.9
Fix
Details: Finally figured out that the DockPanel was catching the keyboard input, and suppressing it when shift+tabbing because the default is Continue mode.
Testing/Validation
Tests Added: No
Reason for not adding tests: 馃槓
Validation: Tried Shift+tab and Tab keys and verified I could cycle both directions through PMUI window (both Solution and Project level). Tried with no package selected (last item is the Thumb separator) and with a package selected (last item is Dependencies treeview).