Add default implementation of IVsSolutionRestoreService4 #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ocallesp This would need to inserted from NuGet side, to get your impl to work. |
erdembayar
reviewed
Jun 1, 2021
src/NuGet.Clients/NuGet.SolutionRestoreManager/VsSolutionRestoreService.cs
Show resolved
Hide resolved
erdembayar
approved these changes
Jun 1, 2021
dominoFire
approved these changes
Jun 2, 2021
src/NuGet.Clients/NuGet.SolutionRestoreManager/VsSolutionRestoreService.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.SolutionRestoreManager/VsSolutionRestoreService.cs
Show resolved
Hide resolved
nkolev92
deleted the
dev-nkolev92-addDefaultImplementationForSolutionRestoreService4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10908
Regression? Last working version:
Description
This would allow dotnet/project-system#7199 to complete, as they'll likely acquire the service via MEF, but currently no one exposes that service.
The real implementation will follow in NuGet/Home#10678.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation