Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create a ProjectRestoreMetadataFrameworkInfo for packages.config/unknown projects in Visual Studio #4127

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jun 28, 2021

Bug

Fixes: NuGet/Home#10924

Regression? Last working version:

Description

NuGet constructs the restore model differently in commandline and VS.

This ensures consistency and fixes the lock file scenario.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team as a code owner June 28, 2021 21:06
@nkolev92 nkolev92 changed the title Fix PR to pc projectreference lock file Always create a ProjectRestoreMetadataFrameworkInfo for packages.config/unknown projects in Visual Studio Jun 28, 2021
@nkolev92
Copy link
Member Author

nkolev92 commented Jul 1, 2021

🔔 @NuGet/nuget-client (feel free to consider this ping as if it's happening on 6/7)

@nkolev92 nkolev92 merged commit d2442f1 into dev Jul 1, 2021
@nkolev92 nkolev92 deleted the dev-nkolev92-fixPRtoPClockFile branch July 1, 2021 23:01
nkolev92 added a commit that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants