Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PackageSaveMode nuspec always reinstalls #4148

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

huangqinjin
Copy link
Contributor

@huangqinjin huangqinjin commented Jul 11, 2021

Bug

Fixes: NuGet/Home#2402

Regression? Last working version: No

Description

Check whether a package with same PackageSaveMode is already installed. That would fix the linked bug.
Enable PackageSaveMode related unit tests.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@huangqinjin huangqinjin requested a review from a team as a code owner July 11, 2021 14:29
@ghost ghost added the Community PRs created by someone not in the NuGet team label Jul 11, 2021
@dnfgituser
Copy link

dnfgituser commented Jul 11, 2021

CLA assistant check
All CLA requirements met.

@erdembayar
Copy link
Contributor

@huangqinjin
Thank you for your contribution. Could you be able to fill description part of your PR?
Also please add unit tests here for your change.

@huangqinjin
Copy link
Contributor Author

@erdembayar done.

@erdembayar
Copy link
Contributor

@erdembayar done.

LGTM. But just in case let's wait others to review it, because I'm not familiar this part of code so there could be edge cases.

@erdembayar
Copy link
Contributor

@NuGet/nuget-client
Please review.

@erdembayar
Copy link
Contributor

@nkolev92
Could be able to take a look here?
LGTM but still not confident to approve. I don't have much experience with PackageSaveMode.

@erdembayar
Copy link
Contributor

@huangqinjin
Thank you for your approval. I'll merge today evening or tomorrow.

@erdembayar erdembayar merged commit 343ec0f into NuGet:dev Aug 5, 2021
@huangqinjin huangqinjin deleted the fix-package-save-mode-nuspec branch August 5, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
4 participants