Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed return value from docs on ISettings.AddOrUpdate #4151

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Removed return value from docs on ISettings.AddOrUpdate #4151

merged 1 commit into from
Jul 13, 2021

Conversation

krafs
Copy link
Contributor

@krafs krafs commented Jul 13, 2021

Bug

Fixes: NuGet/Home#10980

Regression? Last working version:

Description

Removed line from xml comments stating that AddOrUpdate returns a bool, when it actually returns void.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@krafs krafs requested a review from a team as a code owner July 13, 2021 16:48
@ghost ghost added the Community PRs created by someone not in the NuGet team label Jul 13, 2021
@krafs
Copy link
Contributor Author

krafs commented Jul 13, 2021

@zkat

zkat
zkat approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this. :)

@zkat zkat merged commit 8981b49 into NuGet:dev Jul 13, 2021
@zivkan zivkan mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
3 participants
@krafs @zkat @erdembayar