Showing warning icon in packages list items when package version has one or more vulnerabilities

[jebriede]

Bug

Fixes: NuGet/Home#10983

Regression? Last working version: N/A

Description

Added logic to package warning icon to show when package has vulnerabilities, added a tooltip to combine vulnerability and deprecation data when applicable, and added code to reload vulnerability data for package item view model.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[donnie-msft]

First pass...

[dominoFire]

Can you add an UI screenshot showcasing your changes?

Can you run an a11y test pass using https://accessibilityinsights.io/ to ensure not breaking any a11y guidelines?

[dominoFire]

Some comments.

[jebriede]

Can you add an UI screenshot showcasing your changes?

Can you run an a11y test pass using https://accessibilityinsights.io/ to ensure not breaking any a11y guidelines?

@dominoFire

Accessibility Insights was run and came up clean.

[kartheekp-ms]

@jebriede - In the screenshot, you have linked in https://github.com/NuGet/NuGet.Client/pull/4161/files#issuecomment-885871704 comment, I don't see a warning icon next to Installed text in the tab menu. Is that expected or that work is part of another issue?

[kartheekp-ms]

I am sorry If I am missing anything.

1. Is this PR specific to Install tab? How about other tabs such as Browse or Update tab. For e.g. If I am browsing a package in the Browse tab, I don't see any warning icon when the selected package version has a vulnerability.
2. I opened your feature branch and loaded it in the experimental instance of VS, occasionally I don't see a warning icon next to the package version in the install tab.
   

[jebriede]

@jebriede - In the screenshot, you have linked in https://github.com/NuGet/NuGet.Client/pull/4161/files#issuecomment-885871704 comment, I don't see a warning icon next to Installed text in the tab menu. Is that expected or that work is part of another issue?

It's part of another issue: NuGet/Home#10982

[donnie-msft]

@jebriede - In the screenshot, you have linked in https://github.com/NuGet/NuGet.Client/pull/4161/files#issuecomment-885871704 comment, I don't see a warning icon next to Installed text in the tab menu. Is that expected or that work is part of another issue?

@kartheekp-ms I also thought the tab warning icon should be shown, if I recall the spec correctly. Is this a bug or is it intentionally missing?
EDIT: I see there's now a link to a separate issue for this. Assuming PM was okay with that, then the screenshot is OK.

[jebriede]

I am sorry If I am missing anything.

1. Is this PR specific to Install tab? How about other tabs such as Browse or Update tab. For e.g. If I am browsing a package in the Browse tab, I don't see any warning icon when the selected package version has a vulnerability.
2. I opened your feature branch and loaded it in the experimental instance of VS, occasionally I don't see a warning icon next to the package version in the install tab.
   

I'm taking a look right now.

@jebriede - In the screenshot, you have linked in https://github.com/NuGet/NuGet.Client/pull/4161/files#issuecomment-885871704 comment, I don't see a warning icon next to Installed text in the tab menu. Is that expected or that work is part of another issue?

@kartheekp-ms I also thought the tab warning icon should be shown, if I recall the spec correctly. Is this a bug or is it intentionally missing?

@donnie-msft please see #4161 (comment)

[jebriede]

I am sorry If I am missing anything.

1. Is this PR specific to Install tab? How about other tabs such as Browse or Update tab. For e.g. If I am browsing a package in the Browse tab, I don't see any warning icon when the selected package version has a vulnerability.
2. I opened your feature branch and loaded it in the experimental instance of VS, occasionally I don't see a warning icon next to the package version in the install tab.
   

@kartheekp-ms @dominoFire
Thanks again for noticing this. It was missing a OnPropertyChanged event invocation and after fixing, @dominoFire, you, and I tested this thoroughly offline together and it looks good now. Thanks!