Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install packages.config should honor PackageSaveMode #4193

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Install packages.config should honor PackageSaveMode #4193

merged 2 commits into from
Aug 17, 2021

Conversation

huangqinjin
Copy link
Contributor

Bug

Fixes: NuGet/Home#11018

Regression? Last working version: No

Description

nuget restore honors PackageSaveMode. This PR made nuget install honor PackageSaveMode too.

  1. Check whether a package with same PackageSaveMode is already installed.
  2. Install packages with specified mode.
  3. Add tests. (Copied InstallCommand_PackageSaveMode*() with minor changes.)

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@huangqinjin huangqinjin requested a review from a team as a code owner August 11, 2021 08:12
@ghost ghost added the Community PRs created by someone not in the NuGet team label Aug 11, 2021
@erdembayar
Copy link
Contributor

@nkolev92 @kartheekp-ms
Please review.

nkolev92
nkolev92 reviewed Aug 12, 2021
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Some minor test feedback.

test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetInstallCommandTest.cs Outdated Show resolved Hide resolved
@huangqinjin huangqinjin force-pushed the install-packages-config-save-mode branch from 96dba2c to 2ad79a5 Compare August 13, 2021 12:40
@erdembayar erdembayar merged commit 3e86b34 into NuGet:dev Aug 17, 2021
@huangqinjin huangqinjin deleted the install-packages-config-save-mode branch August 18, 2021 02:06
@zivkan zivkan mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

@erdembayar erdembayar erdembayar approved these changes

Assignees
No one assigned
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
3 participants
@huangqinjin @erdembayar @nkolev92