Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use new DependencyGraphSpec #4199

Merged
merged 1 commit into from
Aug 21, 2021
Merged

test: use new DependencyGraphSpec #4199

merged 1 commit into from
Aug 21, 2021

Conversation

mfkl
Copy link
Contributor

@mfkl mfkl commented Aug 12, 2021 •
edited by erdembayar
Loading

Bug

Fixes: NuGet/Home#11168

Regression? Last working version: n/a

Description

newDgSpec was not used in the test so I assume this was overlooked? This PR does not change the test outcome.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@mfkl mfkl requested a review from a team as a code owner August 12, 2021 09:55
@ghost ghost added the Community PRs created by someone not in the NuGet team label Aug 12, 2021
@erdembayar
Copy link
Contributor

@NuGet/nuget-client
Do we need linked issue here? Since there is no product change, I believe we don't need one.

@nkolev92
Copy link
Member

Our policy is issue for every PR.

We have test labels for issues that don't have product changes.

@mfkl mfkl mentioned this pull request Aug 18, 2021
Closed
@erdembayar
Copy link
Contributor

@NuGet/nuget-client
Please review. I'll merge today evening or tomorrow.

@erdembayar erdembayar merged commit dbd9822 into NuGet:dev Aug 21, 2021
@mfkl mfkl deleted the fix-test branch August 23, 2021 02:29
@zivkan zivkan mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

@erdembayar erdembayar erdembayar approved these changes

Assignees
No one assigned
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
3 participants
@mfkl @erdembayar @nkolev92