Update TFM to net7.0 for source-build #4742

lbussell · 2022-08-01T22:45:23Z

Bug

Fixes: NuGet/Home#12000

Regression? Last working version: Not a regression.

Description

I changed all source-build conditioned occurrences of net6.0 TFMs to net7.0.

PR Checklist

lbussell · 2022-08-01T22:45:35Z

cc @crummel

nkolev92 · 2022-08-01T22:47:33Z

build/common.project.props

-    <NETCoreTargetFramework Condition="'$(DotNetBuildFromSource)' == 'true'">net6.0</NETCoreTargetFramework>
-    <NETCoreTestTargetFramework>net6.0</NETCoreTestTargetFramework>
+    <NETCoreTargetFramework Condition="'$(DotNetBuildFromSource)' == 'true'">net7.0</NETCoreTargetFramework>
+    <NETCoreTestTargetFramework>net7.0</NETCoreTestTargetFramework>


Please don't change the target framework in non source build scenarios.
This can cause our builds to fail.

build/common.targets

nkolev92 · 2022-08-01T22:49:41Z

@lbussell
Can you please keep the PR template and create an issue in the home repo as per https://github.com/NuGet/NuGet.Client/blob/dev/CONTRIBUTING.md#contributing-step-by-step

lbussell · 2022-08-02T17:42:44Z

Can you please keep the PR template and create an issue in the home repo

@nkolev92, I filed an issue, updated the PR body with the template, and addressed your review comments - is there a reason the PR validation isn't running?

nkolev92 · 2022-08-02T18:53:08Z

Thanks for the updates @lbussell.

The CI doesn't run automatically for non-NuGet members. I've applied the label and kicked off the validation.

src/NuGet.Core/NuGet.Frameworks/FrameworkConstants.cs

dominoFire

One question, which should not block source-build changes.

src/NuGet.Core/NuGet.PackageManagement/NuGet.PackageManagement.csproj

dominoFire · 2022-08-10T02:58:58Z

@lbussell There are some compiler errors:

D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\FrameworkConstants.cs(15,40): error RS0016: Symbol 'Version7' is not part of the declared API. [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]
D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\FrameworkConstants.cs(190,51): error RS0016: Symbol 'Net70' is not part of the declared API. [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]
D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\PublicAPI.Unshipped.txt(2,1): error RS0017: Symbol 'NuGet.Frameworks.FrameworkConstants.Version7 -> Version' is part of the declared API, but is either not public or could not be found [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]
D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\FrameworkConstants.cs(15,40): error RS0016: Symbol 'Version7' is not part of the declared API. [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]
D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\FrameworkConstants.cs(190,51): error RS0016: Symbol 'Net70' is not part of the declared API. [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]
D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\PublicAPI.Unshipped.txt(2,1): error RS0017: Symbol 'NuGet.Frameworks.FrameworkConstants.Version7 -> Version' is part of the declared API, but is either not public or could not be found [D:\a\_work\1\s\src\NuGet.Core\NuGet.Frameworks\NuGet.Frameworks.csproj]

nkolev92 · 2022-08-16T17:24:23Z

🔔 @lbussell

lbussell · 2022-08-27T00:04:10Z

I'm not sure if I've got the unshipped API format correct - can anyone give me some pointers?

zivkan · 2022-08-27T00:10:25Z

The roslyn analyzer code fix can create the right syntax for you. You're almost certainly not using Windows and therefore Visual Studio is not an option for you, where roslyn analyzers and code fixes run by default. For reasons I don't understand, Omnisharp (or VSCode?) have them disabled by default, but in VSCode's settings I see an option "Omnisharp: Enably Roslyn Analyzers".

zivkan · 2022-08-27T00:12:15Z

Also, if you build locally from the command line (cd to src\NuGet.Core\NuGet.Frameworks, then run dotnet build), the build should fail if the syntax isn't right.

nkolev92 · 2022-08-27T00:38:41Z

src/NuGet.Core/NuGet.Frameworks/FrameworkConstants.cs

@@ -186,6 +187,7 @@ public static class CommonFrameworks
            // .NET 5.0 and later has NetCoreApp identifier
            public static readonly NuGetFramework Net50 = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version5);
            public static readonly NuGetFramework Net60 = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version6);
+            public static readonly NuGetFramework Net70 = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version7);


You can always just not add this change as it's not really anything that requires your change. this is merely an optimization for restore.

lbussell · 2022-08-29T16:37:39Z

I was able to get the project loaded in VS and I included the updates it suggested.

lbussell · 2022-08-31T22:06:26Z

Not sure what the current PR validation failure is - it doesn't look related to my changes:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6620811&view=logs&j=68fd25e5-7968-5c7b-bc0b-13c16b2edd08&t=2fd8befc-7898-5b33-2bea-d02ab5970aca&l=10

nkolev92 · 2022-08-31T22:27:28Z

@lbussell If you rebase it should get fixed.

Ping us here so we can trigger the CI when you've rebased.

lbussell · 2022-09-06T17:56:30Z

I updated the PR again, can we run CI again?

It also looks like the last failure was a timeout - unless you think that's something my change could have caused.

lbussell · 2022-09-06T17:56:41Z

@nkolev92

lbussell · 2022-09-06T20:10:49Z

I also re-ran failed legs from azure devops, looks like mac didn't timeout this time.

lbussell · 2022-09-07T17:05:31Z

Current test failure looks the same as this PR: #4788

Update TFM to net7.0 for source-build

ae91254

lbussell requested a review from a team as a code owner August 1, 2022 22:45

ghost added the Community PRs created by someone not in the NuGet team label Aug 1, 2022

nkolev92 reviewed Aug 1, 2022

View reviewed changes

build/common.targets Show resolved Hide resolved

lbussell added 2 commits August 1, 2022 16:20

Don't change targetframework in non-source-build scenarios

1fe730a

Define IS_CORECLR for net6 target framework

3c6bc35

nkolev92 added the Approved for CI label Aug 2, 2022

nkolev92 reviewed Aug 2, 2022

View reviewed changes

src/NuGet.Core/NuGet.Frameworks/FrameworkConstants.cs Show resolved Hide resolved

aortiz-msft self-requested a review August 4, 2022 20:24

aortiz-msft previously approved these changes Aug 4, 2022

View reviewed changes

dominoFire previously approved these changes Aug 5, 2022

View reviewed changes

src/NuGet.Core/NuGet.PackageManagement/NuGet.PackageManagement.csproj Show resolved Hide resolved

martinrrm assigned nkolev92 Aug 5, 2022

Add Version7 framework constant to public unshipped api list

2648e55

lbussell dismissed stale reviews from dominoFire and aortiz-msft via 2648e55 August 8, 2022 21:31

nkolev92 added Approved for CI and removed Approved for CI labels Aug 8, 2022

MichaelSimons mentioned this pull request Aug 9, 2022

Upgrade all repos targeting net6.0 to net7.0 dotnet/source-build#2966

Closed

dominoFire added Approved for CI and removed Approved for CI labels Aug 9, 2022

lbussell added 2 commits August 26, 2022 16:50

Merge remote-tracking branch 'upstream/dev' into net7.0-tfm

99943d3

Update unshipped API format

1fda71e

zivkan added Approved for CI and removed Approved for CI labels Aug 27, 2022

nkolev92 reviewed Aug 27, 2022

View reviewed changes

Update unshipped API

c850691

nkolev92 approved these changes Aug 29, 2022

View reviewed changes

nkolev92 added Approved for CI and removed Approved for CI labels Aug 29, 2022

zivkan approved these changes Aug 29, 2022

View reviewed changes

Merge branch 'dev' into net7.0-tfm

109a948

zivkan added Approved for CI and removed Approved for CI labels Sep 2, 2022

Merge branch 'dev' into net7.0-tfm

d3a673e

nkolev92 added Approved for CI and removed Approved for CI labels Sep 6, 2022

nkolev92 merged commit a547d19 into NuGet:dev Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update TFM to net7.0 for source-build #4742

Update TFM to net7.0 for source-build #4742

lbussell commented Aug 1, 2022 •

edited by nkolev92

lbussell commented Aug 1, 2022

nkolev92 Aug 1, 2022

nkolev92 commented Aug 1, 2022

lbussell commented Aug 2, 2022

nkolev92 commented Aug 2, 2022

dominoFire left a comment

dominoFire commented Aug 10, 2022 •

edited

nkolev92 commented Aug 16, 2022

lbussell commented Aug 27, 2022

zivkan commented Aug 27, 2022

zivkan commented Aug 27, 2022

nkolev92 Aug 27, 2022

lbussell commented Aug 29, 2022

lbussell commented Aug 31, 2022

nkolev92 commented Aug 31, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 7, 2022

Update TFM to net7.0 for source-build #4742

Update TFM to net7.0 for source-build #4742

Conversation

lbussell commented Aug 1, 2022 • edited by nkolev92

Bug

Description

PR Checklist

lbussell commented Aug 1, 2022

nkolev92 Aug 1, 2022

Choose a reason for hiding this comment

nkolev92 commented Aug 1, 2022

lbussell commented Aug 2, 2022

nkolev92 commented Aug 2, 2022

dominoFire left a comment

Choose a reason for hiding this comment

dominoFire commented Aug 10, 2022 • edited

nkolev92 commented Aug 16, 2022

lbussell commented Aug 27, 2022

zivkan commented Aug 27, 2022

zivkan commented Aug 27, 2022

nkolev92 Aug 27, 2022

Choose a reason for hiding this comment

lbussell commented Aug 29, 2022

lbussell commented Aug 31, 2022

nkolev92 commented Aug 31, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 6, 2022

lbussell commented Sep 7, 2022

lbussell commented Aug 1, 2022 •

edited by nkolev92

dominoFire commented Aug 10, 2022 •

edited