Migrate config command to System.CommandLine #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
reviewed
Dec 20, 2023
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
ghost
removed
the
Status:No recent activity
nkolev92
reviewed
Jan 2, 2024
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/ConfigCommands/ConfigCommand.cs
Outdated
Show resolved
Hide resolved
nkolev92
previously approved these changes
Jan 5, 2024
Nigusu-Allehu
previously approved these changes
Jan 5, 2024
jeffkl
dismissed stale reviews from Nigusu-Allehu and nkolev92
The base branch was changed.
Added DotNet Nuget Config Paths command
Adds NuGet config get command
Added Dotnet NuGet config unset command
Adds Dotnet NuGet config set command
martinrrm
force-pushed
the
dev-feature-migrate-dotnet-nuget-config
branch
from
cb550f3
to
813517b
Compare
nkolev92
approved these changes
Jan 10, 2024
| @@ -74,7 +74,7 @@ public static int MainInternal(string[] args, CommandOutputLogger log) | |||
|
|
|||
| NuGet.Common.Migrations.MigrationRunner.Run(); | |||
|
|
|||
| if (args.Count() >= 2 && args[0] == "package" && args[1] == "search") | |||
| if ((args.Count() >= 2 && args[0] == "package" && args[1] == "search") || (args.Any() && args[0] == "config")) | |||
There was a problem hiding this comment.
We should be using length > 0 in all of these.
Perf isn't critical here, but it's good to be in the habit of using the performant option.
|
We never documented this feature. There's no documentation issue that I could find. I created: NuGet/Home#13398 |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12686
Regression? Last working version:
Description
This PR changes the config command to use the package System.CommandLine.
This PR also includes the implementation of the commands since they were never merged to dev, Program.cs and ConfigCommand.cs are the actual changes related to the migration.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation