NuGetAudit must not cause restore to fail #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Jan 24, 2024
|
It's really not clear to me how to solve the unhandled exceptions. Where and how should the errors be reported to customers in VS? How should the error be shown on the CLI? Should a "fake" assets file be created and written out? If I was to work on it, it'd take me significantly longer than what this PR has already taken me, so I think it's better off as a different issue/PR. |
nkolev92
approved these changes
Jan 25, 2024
jeffkl
approved these changes
Jan 25, 2024
|
Solves customer feedback: https://developercommunity.visualstudio.com/t/dotnetexe-80200-cannot-restore-from/10597271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13085
Regression? no
Description
While the vulnerability info resource is designed to fail gracefully (not throw, return a result object with an exception), if restore didn't need to talk to any sources before running audit, then getting the service index, or getting the vulnerability resource from the service index can throw. This needs to be guarded because Audit should never cause a build to fail (unless customers opt into warnings as errors)
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation