Reduce boxing when enumerating lists #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
Approved for CI
Community
jeffkl
previously approved these changes
Mar 1, 2024
jeffkl
reviewed
Mar 4, 2024
| @@ -123,7 +123,29 @@ private static bool TryConvertOrNormalize(string key, IDictionary<string, string | |||
| } | |||
| else if (reverse.ContainsKey(key)) | |||
| { | |||
| value = reverse.Where(p => StringComparer.OrdinalIgnoreCase.Equals(p.Key, key)).Select(s => s.Key).Single(); | |||
| bool found = false; | |||
There was a problem hiding this comment.
I just realized this is getting a value from a dictionary, can't this just be:
else if (reverse.ContainsKey(key))
{
foreach (KeyValuePair<string, string> item in reverse)
{
if (StringComparer.OrdinalIgnoreCase.Equals(item.Key, key))
{
value = item.Key;
return true;
}
}
}There was a problem hiding this comment.
Definitely! That's much cleaner. Added NoAllocEnumerate() as well to avoid the enumerator boxing where possible too.
jeffkl
approved these changes
Mar 4, 2024
nkolev92
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13279
Regression? Last working version:
Description
Reduces boxing by expanding LINQ queries, using
.Countinstead of.Any(), and uses.NoAllocEnumerate()where possible.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation